-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #3660: Add Numeric type #4319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
added
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
labels
Feb 22, 2024
Erigara
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
outoftardis,
0x009922,
DCNick3,
VAmuzing,
Asem-Abdelhady and
horizenight
as code owners
February 22, 2024 11:57
github-actions
bot
added
api-changes
Changes in the API for client libraries
config-changes
Changes in configuration and start up of the Iroha
labels
Feb 22, 2024
Erigara
force-pushed
the
numeric
branch
2 times, most recently
from
February 22, 2024 12:54
e5a271b
to
82fe5b0
Compare
Pull Request Test Coverage Report for Build 8170013578Details
💛 - Coveralls |
DCNick3
reviewed
Feb 22, 2024
DCNick3
reviewed
Feb 22, 2024
DCNick3
reviewed
Feb 22, 2024
DCNick3
reviewed
Feb 22, 2024
DCNick3
reviewed
Feb 22, 2024
DCNick3
reviewed
Feb 22, 2024
DCNick3
reviewed
Feb 22, 2024
I think this is very good. I currently have to expose this to library users and have them correctly match "Quantity" and "BigQuantity" et cetera. Having it all be the same type is much better. |
SamHSmith
previously approved these changes
Feb 23, 2024
mversic
requested changes
Feb 23, 2024
Signed-off-by: Shanin Roman <[email protected]>
mversic
reviewed
Mar 1, 2024
…` for `Asset`s Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
…ic!` Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
… conversion Signed-off-by: Shanin Roman <[email protected]>
mversic
reviewed
Mar 1, 2024
mversic
reviewed
Mar 1, 2024
mversic
reviewed
Mar 1, 2024
mversic
reviewed
Mar 1, 2024
mversic
approved these changes
Mar 1, 2024
mversic
previously approved these changes
Mar 4, 2024
5 tasks
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
SamHSmith
previously approved these changes
Mar 6, 2024
mversic
approved these changes
Mar 6, 2024
SamHSmith
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce unified decimal numeric type for assets, no more
Quantity
,BigQuantity
,Fixed
.Type is represented as
96bit
mantissa +scale
up to 28 decimal places.Linked issue
Closes #3660
Benefits
Simplified code, decimals commonly use in monetary applications.