Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4126: test to prevent cross chain replay attacks #4257

Closed
wants to merge 12 commits into from
Closed

[refactor] #4126: test to prevent cross chain replay attacks #4257

wants to merge 12 commits into from

Conversation

timofeevmd
Copy link
Contributor

Description

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

Signed-off-by: timofeevmd <[email protected]>

Signed-off-by: timofeevmd <[email protected]>
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 6, 2024
@timofeevmd timofeevmd changed the title [refactor] #4126, #4219: test to prevent cross chain replay attacks [refactor] #4126: test to prevent cross chain replay attacks Feb 6, 2024
client/tests/integration/mod.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chainid.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chainid.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chainid.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chainid.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chainid.rs Outdated Show resolved Hide resolved
…e/tx_chain_id

# Conflicts:
#	client/tests/integration/tx_chainid.rs
@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8143526249

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3648 unchanged lines in 60 files lost coverage.
  • Overall coverage decreased (-0.3%) to 56.53%

Files with Coverage Reduction New Missed Lines %
core/src/sumeragi/network_topology.rs 1 98.78%
tools/kagami/src/crypto.rs 1 12.12%
data_model/src/metadata.rs 2 78.87%
primitives/src/unique_vec.rs 2 91.24%
config/src/kura.rs 3 80.0%
config/src/logger.rs 5 72.73%
logger/src/lib.rs 5 94.12%
tools/kagami/src/main.rs 5 0.0%
data_model/src/smart_contract.rs 7 0.0%
telemetry/src/dev.rs 7 0.0%
Totals Coverage Status
Change from base Build 7884695009: -0.3%
Covered Lines: 22516
Relevant Lines: 39830

💛 - Coveralls

@timofeevmd timofeevmd closed this by deleting the head repository Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants