[refactor] #3068: remove flattened events #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara and
0x009922
as code owners
github-actions
bot
added
the
iroha2-dev
DCNick3
force-pushed
the
event-refactor
branch
from
146b307 to
c1af15d
Compare
DCNick3
force-pushed
the
event-refactor
branch
from
c1af15d to
4a97fde
Compare
Arjentix
reviewed
Dec 25, 2023
DCNick3
force-pushed
the
event-refactor
branch
2 times, most recently
from
5a8bdfc to
841ecd5
Compare
Erigara
approved these changes
Dec 25, 2023
DCNick3
force-pushed
the
event-refactor
branch
from
841ecd5 to
32eeb62
Compare
Signed-off-by: Nikita Strygin <[email protected]>
DCNick3
force-pushed
the
event-refactor
branch
from
32eeb62 to
8844d57
Compare
Arjentix
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes duplicated flattened events. Those are events like the
DataEvent::Account(_)andDataEvent::Asset(_). They are already present under other event types (DataEvent::Domain(DomainEvent::Account(_)), for example) and were duplicated to simplify the event filter construction (?).While an immediate effect of this change is ever more increased amount of boilerplate to construct event filters, this provides a more orthogonal events system, helping to build a comprehensive DSL.
Linked issue
Partially addresses #3068
Checklist