Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3237: Expose cargo's output in wasm_builder_cli to have build progress information #4007

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

DCNick3
Copy link
Contributor

@DCNick3 DCNick3 commented Oct 19, 2023

Description

This adds a progress bar to wasm_builder_cli by exposing cargo's output (which already implements progress bar).

Linked issue

Closes #3237

Benefits

The user can see the progress of the build

Checklist

  • Make CI pass

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 19, 2023
@coveralls
Copy link

coveralls commented Oct 19, 2023

Pull Request Test Coverage Report for Build 6586229893

  • 0 of 43 (0.0%) changed or added relevant lines in 2 files are covered.
  • 6859 unchanged lines in 128 files lost coverage.
  • Overall coverage decreased (-3.4%) to 55.996%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/wasm_builder_cli/src/main.rs 0 4 0.0%
wasm_builder/src/lib.rs 0 39 0.0%
Files with Coverage Reduction New Missed Lines %
client/src/lib.rs 1 0.0%
cli/src/torii/pagination.rs 1 98.9%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 96.43%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/base/derive/src/proxy.rs 2 98.11%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
Totals Coverage Status
Change from base Build 5423219773: -3.4%
Covered Lines: 21909
Relevant Lines: 39126

💛 - Coveralls

@DCNick3 DCNick3 marked this pull request as ready for review October 19, 2023 08:56
@Erigara Erigara self-assigned this Oct 19, 2023
…ild progress information

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 DCNick3 force-pushed the wasm-builder-progress branch from f741649 to 922aad9 Compare October 20, 2023 09:59
@DCNick3 DCNick3 merged commit da700da into iroha2-dev Oct 20, 2023
8 checks passed
@nxsaken nxsaken deleted the wasm-builder-progress branch May 28, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants