Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] History fix / signoff #3994

Merged
merged 55 commits into from
Oct 17, 2023
Merged

[chore] History fix / signoff #3994

merged 55 commits into from
Oct 17, 2023

Conversation

6r1d
Copy link
Contributor

@6r1d 6r1d commented Oct 17, 2023

Fixes the signoff in f0b2092 by adding a signoff in 483b6d5c

6r1d and others added 30 commits October 17, 2023 08:27
@6r1d
[refactor] #3875: Fix authentication/authorization docstring (#3876)
483b6d5 
Signed-off-by: 6r1d <[email protected]>
@Arjentix @6r1d
[feature] #3868: Add iroha_swarm disclaimer header
3ffa799 
Signed-off-by: Daniil Polyakov <[email protected]>
@DCNick3 @6r1d
[refactor] #3526: Allow only a fixed set of signature verification co…
c680543 
…nditions

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #3526: Add signature check condition unit tests
4c7ef1f 
Signed-off-by: Nikita Strygin <[email protected]>
@Erigara @6r1d
[feature] #1915: Implement Fast kura init mode
8c4c94f 
Signed-off-by: Shanin Roman <[email protected]>
@Erigara @6r1d
[fix]: Don't fail if dir exists in test_env.py
a062515 
Signed-off-by: Shanin Roman <[email protected]>
@mversic @6r1d
[feature] #3355: Standardize block API (#3884)
4b3f66b 
Co-authored-by: Shanin Roman <[email protected]>
[fix] #3890: Fix validate topology on block sync

Signed-off-by: Marin Veršić <[email protected]>
@BAStos525 @6r1d
[ci] #3849: Fix stable/lts configs pushing job (#3894)
2f3b134 
Signed-off-by: BAStos525 <[email protected]>
@DCNick3 @6r1d
[ci] #3622: Use cargo manifest lints instead of unmaintained cargo-lints
9f77e55 
Since the implementation of rust-lang/rfcs#3389, it is now possible to specify workspace-level lints for rustc and clippy. This PR updates the cargo configuration and CI to use this new feature instead of cargo-lints.

Note that it was only stabilized in `nightly-2023-09-10`. Using it with out current toolchain requires either a -Zlints flag or a modification to `.cargo/config.toml`:

```
[unstable]
lints = true
```

Note that unlike the original suggestion in #3622, this doesn't make the lints crate level, but merely replaces a clunky unmaintained tool with a standard solution for configuring lints.

In particular this PR:
- Removes old lints.toml configuration files for cargo-lints
- Adds [lint] tables to Cargo.toml of the root and wasm workspaces. The lints are duplicated between the two
- Replaces `cargo lints clippy` invocations with `cargo clippy -Zlints` in CI scripts
- Silences/fixes some new lints that popped up due to differences in how between `cargo lints` and workspaces
- Does a drive-by fix to iroha_genesis: it now too shares cargo metadata as do other crates

Signed-off-by: Nikita Strygin <[email protected]>
@0x009922 @6r1d
[fix]: mkdir -r with store path, not lock path (#3908)
389eb28 
* [fix]: `mkdir -r` with store path, not lock path

Signed-off-by: Dmitry Balashov <[email protected]>

* [fix]: use `store_path` in the err

Signed-off-by: Dmitry Balashov <[email protected]>

* [refactor]: `&`

Signed-off-by: Dmitry Balashov <[email protected]>

* [refactor]: apply lint

Signed-off-by: Dmitry Balashov <[email protected]>

---------

Signed-off-by: Dmitry Balashov <[email protected]>
@Erigara @6r1d
[fix] #3906: Fix wasm memory leak
867fc37 
Signed-off-by: Shanin Roman <[email protected]>
@Erigara @6r1d
[fix] #3905: Fix apply_blocks and validate_blocks benchmark
90009de 
Signed-off-by: Shanin Roman <[email protected]>
@DCNick3 @6r1d
[refactor] #3882: Update iroha_data_model_derive to use syn 2.0
d6ea22b 
Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #3882: Make derive(Filter) use darling
3c6e97a 
Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #3882: Make derive(IdEqOrdHash) use darling, add tests
6544040 
Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #3882: Make PartiallyTaggedSerialize/Deserialize use darling
a2f280a 
Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[feature] #3737: Add support for usage of Self type in serde partiall…
017ddff 
…y tagged enums

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #2437: Improve naming, simplify repeated .filter_maps & ge…
d1380a5 
…t rid of unnecessary .except in derive(Filter)

This addresses the last of the concerns raised in #2437

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #3882: Add tests for derive(HasOrigin) macro, reduce repet…
53491a4 
…ition in derive(IdEqOrdHash), fix error reporting on stable

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #3882: Clean up Emitter APIs documentation to make clippy …
ea20c6b 
…happy

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 @6r1d
[refactor] #3882: Add basic generics support to derive(HasOrigin)
d06bc33 
Signed-off-by: Nikita Strygin <[email protected]>
@mversic @6r1d
[refactor]: Replace Registered with Identifiable in ISI bounds (#3925)
9d6c35e 
Signed-off-by: Marin Veršić <[email protected]>
@0x009922 @6r1d
[feature]: parse filter as JSON5 in iroha_client_cli (#3923)
0fa1ca4 
[feat]: parse filter as JSON5 in `iroha_client_cli`

Signed-off-by: Dmitry Balashov <[email protected]>
@outoftardis @6r1d
[documentation]: Remove the develop-iroha-module guide (#3907)
2963457 
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
@Arjentix @6r1d
[fix] #3899: Fix topology mismatch bug (#3903)
dc05218 
Signed-off-by: Daniil Polyakov <[email protected]>
@DCNick3 @6r1d
[refactor] #3911: Migrate iroha_futures_derive to syn 2.0
6ebe32b 
Also, a drive-by fix to silence the "unused" lints in some other feature combinations

Signed-off-by: Nikita Strygin <[email protected]>
@BAStos525 @6r1d
[ci] #3825: Clean default runner free space (#3902)
a9958c0 
Signed-off-by: BAStos525 <[email protected]>
@mversic @6r1d
[refactor] #3895: move commit_topology into block payload (#3916)
539c3f9 
Signed-off-by: Marin Veršić <[email protected]>
@mversic @6r1d
[refactor] #3886: Remove 'Versioned' prefix from versioned containers (…
88b289d 
…#3913)

Signed-off-by: Marin Veršić <[email protected]>
@mversic @6r1d
[refactor]: Rename ISI from *Box to *Expr (#3930)
9aa90bf 
Signed-off-by: Marin Veršić <[email protected]>
Erigara and others added 10 commits October 17, 2023 08:27
@Erigara @6r1d
[feature] #3953: Transfer Domain ownership
83e87f2 
Signed-off-by: Shanin Roman <[email protected]>
@benhhack @6r1d
[refactor] #3874: Remove IsAssetDefinitionOwner (#3979)
9861f46 
Signed-off-by: benhhack <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
@mversic @6r1d
[refactor] #3918: Rename validator to executor (#3976)
afe4785 
Signed-off-by: Marin Veršić <[email protected]>
@6r1d
[fix] #0000: proper rustc in devShell
3c8b15e 
Signed-off-by: Artemii Gerasimovich <[email protected]>
@0x009922 @6r1d
[docs]: Remove api_spec.md (#3968)
8dee8d2
@Arjentix @6r1d
[fix] #0000: Fix executor downloading in update_configs.sh (#3990)
42c1a0f 
Signed-off-by: Daniil Polyakov <[email protected]>
@mversic @6r1d
[refactor]: bump dependencies (#3981)
ee62def 
Signed-off-by: Marin Veršić <[email protected]>
@6r1d
[feature] #3516: make FindTrigger queries return original WASM
2932a33 
Signed-off-by: Artemii Gerasimovich <[email protected]>
@6r1d
[refactor] remove optimized WASM from data_model
445c1df 
Signed-off-by: Artemii Gerasimovich <[email protected]>
@mversic @6r1d
[refactor]: remove unused dependencies (#3992)
25aaede 
Signed-off-by: Marin Veršić <[email protected]>
@6r1d 6r1d self-assigned this Oct 17, 2023
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 17, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6542959994

  • 2161 of 4454 (48.52%) changed or added relevant lines in 128 files are covered.
  • 4979 unchanged lines in 105 files lost coverage.
  • Overall coverage decreased (-3.4%) to 56.039%
Changes Missing Coverage Covered Lines Changed/Added Lines %
config/base/src/runtime_upgrades.rs 2 3 66.67%
core/src/gossiper.rs 0 1 0.0%
core/src/queue.rs 28 29 96.55%
core/src/smartcontracts/isi/asset.rs 1 2 50.0%
core/src/smartcontracts/isi/tx.rs 4 5 80.0%
crypto/src/hash.rs 5 6 83.33%
ffi/src/option.rs 0 1 0.0%
ffi/src/repr_c.rs 5 6 83.33%
p2p/src/peer.rs 0 1 0.0%
primitives/src/small.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
client/src/lib.rs 1 0.0%
cli/src/torii/pagination.rs 1 98.9%
config/base/src/runtime_upgrades.rs 1 50.0%
config/src/sumeragi.rs 1 56.0%
config/src/torii.rs 1 96.43%
core/src/gossiper.rs 1 0.0%
core/src/smartcontracts/isi/block.rs 1 87.5%
crypto/src/merkle.rs 1 96.23%
data_model/derive/src/id.rs 1 86.11%
data_model/src/domain.rs 1 48.25%
Totals Coverage Status
Change from base Build 5423219773: -3.4%
Covered Lines: 21923
Relevant Lines: 39121
💛 - Coveralls

@6r1d 6r1d merged commit 14e1411 into iroha2-dev Oct 17, 2023
12 of 13 checks passed
@nxsaken nxsaken deleted the grid_history_fix branch May 28, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStroke AlexStroke AlexStroke approved these changes

@mversic mversic mversic approved these changes

@Erigara Erigara Erigara approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@appetrosyan appetrosyan Awaiting requested review from appetrosyan

@Arjentix Arjentix Awaiting requested review from Arjentix

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@0x009922 0x009922 Awaiting requested review from 0x009922

@DCNick3 DCNick3 Awaiting requested review from DCNick3

Assignees

@6r1d 6r1d

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.