[refactor] #3874: Remove IsAssetDefinitionOwner

[benhhack]

Notes

Two previous pull requests for the issue were closed without merge because of conflicts and messy commit histories. See #3919 #3920 . I have followed all the discussed steps in #3920 but some tests (in mod.rs) are still failing.

Linked issue

This query was introduced only for the purposes of validator. Since #3442 we can use FindAssetDefinitionById to do the exact same thing.

Closes #3874

Checklist

• I've read CONTRIBUTING.md
• I've used the standard signed-off commit format (or will squash just before merging)
• All applicable CI checks pass (or I promised to make them pass later)
• (optional) I've written unit tests for the code changes
• I replied to all comments after code review, marking all implemented changes with thumbs up

[coveralls]

Pull Request Test Coverage Report for Build 6468999535

• 17 of 58 (29.31%) changed or added relevant lines in 7 files are covered.
• 6488 unchanged lines in 109 files lost coverage.
• Overall coverage decreased (-3.4%) to 56.016%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
data_model/derive/src/lib.rs	0	1	0.0%
ffi/derive/src/attr_parse/getset.rs	6	7	85.71%
ffi/derive/src/attr_parse/derive.rs	3	5	60.0%
data_model/derive/src/filter.rs	0	12	0.0%
ffi/derive/src/convert.rs	5	30	16.67%

Files with Coverage Reduction	New Missed Lines	%
cli/src/main.rs	1	0.0%
cli/src/torii/pagination.rs	1	98.9%
config/src/torii.rs	1	96.43%
core/src/smartcontracts/isi/block.rs	1	87.5%
crypto/src/merkle.rs	1	96.23%
logger/src/lib.rs	1	95.15%
config/src/lib.rs	2	0.0%
logger/src/layer.rs	2	48.05%
cli/src/samples.rs	3	0.0%
data_model/derive/src/has_origin.rs	3	95.16%

Totals
Change from base Build 5423219773:	-3.4%
Covered Lines:	21933
Relevant Lines:	39155

---

💛 - Coveralls