Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] proper rustc in devShell #3967

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

QuentinI
Copy link
Contributor

@QuentinI QuentinI commented Oct 6, 2023

Description

Small tweak to fix rustc in devShell not finding sysroot.

Linked issue

None

Benefits

Usable rustc in devShell

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 6, 2023
@QuentinI QuentinI force-pushed the fix/nix-flake branch 3 times, most recently from 863c863 to dec9f9c Compare October 6, 2023 17:15
pesterev
pesterev previously approved these changes Oct 6, 2023
mversic
mversic previously approved these changes Oct 9, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6483708865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6380 unchanged lines in 107 files lost coverage.
  • Overall coverage decreased (-3.4%) to 56.019%

Files with Coverage Reduction New Missed Lines %
cli/src/main.rs 1 0.0%
cli/src/torii/pagination.rs 1 98.9%
config/src/torii.rs 1 96.43%
core/src/smartcontracts/isi/block.rs 1 87.5%
crypto/src/merkle.rs 1 96.23%
logger/src/lib.rs 1 95.15%
config/src/lib.rs 2 0.0%
logger/src/layer.rs 2 48.05%
cli/src/samples.rs 3 0.0%
data_model/derive/src/has_origin.rs 3 95.16%
Totals Coverage Status
Change from base Build 5423219773: -3.4%
Covered Lines: 21933
Relevant Lines: 39153

💛 - Coveralls

@QuentinI QuentinI dismissed stale reviews from mversic and pesterev via b75b0ad October 12, 2023 13:27
Signed-off-by: Artemii Gerasimovich <[email protected]>
@QuentinI QuentinI merged commit f5df085 into hyperledger-iroha:iroha2-dev Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants