Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] #3945: Update MAINTAINERS.md #3946

Merged
merged 2 commits into from
Nov 27, 2023
Merged

[documentation] #3945: Update MAINTAINERS.md #3946

merged 2 commits into from
Nov 27, 2023

Conversation

6r1d
Copy link
Contributor

@6r1d 6r1d commented Oct 3, 2023

Before merging, please comment on Aleksandr's role, because he's more of an advisor at this point.

MAINTAINERS.md Outdated Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
MAINTAINERS.md Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
@Mingela
Copy link
Contributor

Mingela commented Oct 3, 2023

shouldn't we add QAs?

@6r1d
Copy link
Contributor Author

6r1d commented Oct 3, 2023

As far as I am aware, we have no other QAs besides Alexander Strokov and Michael Timofeev.

@6r1d 6r1d force-pushed the staff_changes branch 3 times, most recently from 25fa0ee to d6d07ef Compare October 5, 2023 07:03
@6r1d 6r1d force-pushed the staff_changes branch 6 times, most recently from db25b7b to 39fe315 Compare October 30, 2023 19:41
@6r1d 6r1d marked this pull request as ready for review October 30, 2023 19:41
@mversic
Copy link
Contributor

mversic commented Nov 13, 2023

@Mingela can we merge this as it is?

mversic
mversic previously approved these changes Nov 20, 2023
@Mingela
Copy link
Contributor

Mingela commented Nov 20, 2023

@mversic @6r1d should we also add the newcomers?

Mingela
Mingela previously approved these changes Nov 20, 2023
@mversic
Copy link
Contributor

mversic commented Nov 20, 2023

@mversic @6r1d should we also add the newcomers?

yes we just agreed to add Vladislav, is there anyone else?

@Mingela
Copy link
Contributor

Mingela commented Nov 20, 2023

@mversic @6r1d should we also add the newcomers?

yes we just agreed to add Vladislav, is there anyone else?

the intern maybe, up to you

Signed-off-by: 6r1d <[email protected]>

Co-authored-by: Bogdan Mingela <[email protected]>
Signed-off-by: Victor <[email protected]>
Signed-off-by: 6r1d <[email protected]>
@6r1d 6r1d dismissed stale reviews from Mingela and mversic via d6e6e24 November 23, 2023 13:54
@mversic mversic requested a review from Mingela November 23, 2023 14:07
@6r1d 6r1d merged commit 94f02d1 into main Nov 27, 2023
34 of 41 checks passed
@6r1d 6r1d deleted the staff_changes branch November 27, 2023 08:18
baziorek pushed a commit to dominious1/iroha that referenced this pull request Jan 26, 2024
baziorek pushed a commit to dominious1/iroha that referenced this pull request Jan 26, 2024
dominious1 pushed a commit to dominious1/iroha that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants