-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iroha_wasm_builder
progress-bar
#3237
Comments
Blocked by #2152 |
I use a spinner in We can probably reuse it in |
This issue is partially addressed by That PR introduces |
I've decided to go with option 1, with possibly switching to 2 if some limitations are to be found |
…ild progress information Signed-off-by: Nikita Strygin <[email protected]>
…ild progress information Signed-off-by: Nikita Strygin <[email protected]>
…ild progress information Signed-off-by: Nikita Strygin <[email protected]>
…ough ursa Signed-off-by: Nikita Strygin <[email protected]>
…pt to iroha_crypto types Signed-off-by: Nikita Strygin <[email protected]>
…ode from ursa Signed-off-by: Nikita Strygin <[email protected]>
…20Poly1305 code from ursa, migrate iroha_p2p to use it Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Nikita Strygin <[email protected]>
…o blocks This also removes bls signature aggregation and rogue key mitigation, as iroha does not and probably will not use aggregated signatures Signed-off-by: Nikita Strygin <[email protected]>
This makes all the dependency tree of iroha_crypto wasm-compatible (except `getrandom`, which either requires a "js" feature enabled when used from web, or a custom getrandom implementation in other cases) Signed-off-by: Nikita Strygin <[email protected]>
…tests Clean up the API a bit: - hide the implementation details of signatures (they are only used through the PublicKey, PrivateKey and Signature types) - remove even more unused API functions - add missing documentation items Signed-off-by: Nikita Strygin <[email protected]>
…ough ursa Signed-off-by: Nikita Strygin <[email protected]>
…pt to iroha_crypto types Signed-off-by: Nikita Strygin <[email protected]>
…ode from ursa Signed-off-by: Nikita Strygin <[email protected]>
…20Poly1305 code from ursa, migrate iroha_p2p to use it Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Nikita Strygin <[email protected]>
…o blocks This also removes bls signature aggregation and rogue key mitigation, as iroha does not and probably will not use aggregated signatures Signed-off-by: Nikita Strygin <[email protected]>
This makes all the dependency tree of iroha_crypto wasm-compatible (except `getrandom`, which either requires a "js" feature enabled when used from web, or a custom getrandom implementation in other cases) Signed-off-by: Nikita Strygin <[email protected]>
…tests Clean up the API a bit: - hide the implementation details of signatures (they are only used through the PublicKey, PrivateKey and Signature types) - remove even more unused API functions - add missing documentation items Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
- make the signature implementations not use the &self, they are all stateless anyway - remove redundant Result returns - add docs on errors Signed-off-by: Nikita Strygin <[email protected]>
It will be nice to have a way to get information about current progress of build from
iroha_wasm_builder
.As an example of current implementation you can run
kagami validator
and will see, that it looks like it's stucked.I believe, there is a way to provide this info from
iroha_wasm_builder
crate and the display it on user side.The text was updated successfully, but these errors were encountered: