[feature] #224: Ursa bump to edition 2021 and trivial dependencies #225
Conversation
| @@ -26,30 +26,37 @@ jobs: | |||
| - name: Build | |||
| working-directory: ${{ matrix.workdir }} | |||
| run: cargo build --verbose | |||
| if: always() | |||
There was a problem hiding this comment.
Ensure if someone forgot to format, and docs, and has live lints, that they use
appetrosyan
force-pushed
the
main
branch
2 times, most recently
from
0ee4c27 to
e03edfb
Compare
| wasm-bindgen = { version = "0.2", optional = true, features = ["serde-serialize"] } | ||
| x25519-dalek = { version = "1.1", optional = true, default-features = false } | ||
| zeroize = { version = "1.1", features = ["zeroize_derive"], optional = true } | ||
| x25519-dalek = { version = "1.2.1", optional = true, default-features = false, git = "https://github.com/appetrosyan/x25519-dalek" } |
There was a problem hiding this comment.
Relevant PR:
There was a problem hiding this comment.
Do we want this vendored like this?
There was a problem hiding this comment.
This is temporary until the PR into dalek is accepted. While the lib is small, other projects would benefit from unpinning dalek from old zeroize
There was a problem hiding this comment.
alternatively, could we point to the dalek 2.0 release branch? https://github.com/dalek-cryptography/x25519-dalek/tree/release/2.0
There was a problem hiding this comment.
Its seems v2.0.0-rc.2 has been released to crates.io, so that could be used.
There was a problem hiding this comment.
Sadly, 2.0.0-rc.2 has the wrong version of rand for this PR to not also have to change a few APIs. I'm afraid the vendoring will have to stay for now.
There was a problem hiding this comment.
Its seems v2.0.0-rc.2 has been released to crates.io, so that could be used.
Unfortunately, that version uses the incorrect version of rand, so we can't really upgrade to that one yet.
For now, I'm afraid the vendoring is the best option. Given that we don't have any semver guarantees just yet, I'll accompany that change with a semver bump.
appetrosyan
changed the title
|
@brentzundel thoughts? |
|
It was my understanding that @appetrosyan was planning to update the reference to Dalek to no longer point at his personal repository. At that point I'm happy to approve and merge. |
ryjones
force-pushed
the
main
branch
3 times, most recently
from
c7eee07 to
f82333c
Compare
…ition 2021 Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
I'm afraid that this is not an option as of yet. To upgrade to |
|
@appetrosyan please see #233 |
Simple version bump for all Rust edition 2015 idioms.
Description of change
cargo fix --editionIssues
Closes #224
Testing
Tests added
No extra tests added
Existing tests
Not altered
Local test runs
Apple M2 - Pending
Discussion
## Pros
Cons
Special comments
Change of MSRV