Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages jison's ability to precompile a parser to greatly reduce the size of the final bundle, from 331kb to 30kb.
A npm command and
grammar.json
file replaces the originalparser.js
, and the stateful lexer is added to the runner after the parser is required.All tests are passing
Also, moves the build system to esbuild, to reduce complexity and accessibility of the build.
Let me know what you think!
Edit: I'm seeing that the Travis CI tests fail with the esbuild, I'm kinda assuming because its testing a lower node version. I can certainly modify this to use the old build system, but keep the precompile thing. Is there a reason we are testing against a lower node version (<=5)?