-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 파이어베이스과 Oauth 공급자 연결 #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- api.js 파일을 생성하여 axios로 요청을 보내는 함수들을 정리 - firebase.js 파일에서 fbSignUp 함수를 통해 firebase 회원가입 처리 ref: #67
- 로직은 firebase.js 파일 내에서 처리하도록 수정 ref: #67
- 로직은 firebase.js 파일 내에서 처리하도록 수정 ref: #67
- Root 컴포넌트에서 현재 로그인 상태를 확인 - 로그인 O: Outlet 렌더링 - 로그인 X: 로그인 페이지로 이동 ref: #67
- 사용자가 로그인 중일 때는 인증 화면으로 갈 수 없도록 구현 ref: #67
- checkUserExist 함수 삭제 - getMe 함수에 user가 존재하는지 확인하는 로직 추가
- 회원가입 성공 시, 입력받은 data를 백엔드로 전송하는 로직 추가
- fbCreateCustomToken ref: #67
Muon05
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yangjiwoong1
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입
작업 내용
관련 이슈: #67
테스트 결과
PR 체크리스트