[Example] Add ALS application #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kygx-legend
requested changes
Mar 15, 2017
examples/CMakeLists.txt
Outdated
| target_link_libraries(ALS ${HUSKY_EXTERNAL_LIB}) | ||
| husky_default_properties(ALS) | ||
|
|
||
| # Triangle counting |
examples/als.cpp
Outdated
| // | ||
| // Example of configuration | ||
| // | ||
| // master_host=master |
There was a problem hiding this comment.
No need to put all information of configuration here. Be selective.
examples/als.cpp
Outdated
| pred = std::max(1., pred); | ||
| pred = std::min(5., pred); | ||
| double loss = pred - rating; | ||
| // husky::LOG_I << "pred: " << pred; |
There was a problem hiding this comment.
Remove all unused comments like this.
kygx-legend
changed the title
|
Actually it's better to use BroadcastChannel instead. However we need a proper BroadcastChannel first. See https://github.com/ddmbr/husky-h4/issues/116 and https://github.com/ddmbr/husky-h4/pull/115. A proper BroadcastChannel also exists in the old Husky repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using push channel to implement an example of ALS.