Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add A01 #199

Merged
merged 8 commits into from
Apr 9, 2024
Merged

refactor: add A01 #199

merged 8 commits into from
Apr 9, 2024

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Apr 8, 2024

No description provided.

@Lash-L Lash-L requested a review from humbertogontijo April 8, 2024 15:32
humbertogontijo
humbertogontijo previously approved these changes Apr 8, 2024
View reviewed changes
Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Lash-L Lash-L changed the title major: add A01 refactor: add A01 Apr 8, 2024
@Lash-L
feat: add a01
f7947fc 
BREAKING CHANGE: You must now specify what version api you want to use with clients.
@Lash-L Lash-L requested a review from humbertogontijo April 8, 2024 19:53
@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 8, 2024

Okay I finally figured out how to get the major release to work, so I just need another approval and I can fix it. You can ignore commitlint as I will squash commits anyways.

@Lash-L Lash-L merged commit 16b9e3e into main Apr 9, 2024
6 of 7 checks passed
@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 9, 2024

@humbertogontijo It failed to publish to pypi because your email is not verified, could you verify it? You may also need to setup 2FA

@humbertogontijo
Copy link
Owner

I think my GH token expired.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 9, 2024

coudl be both things
image

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 9, 2024

I removed the old release and tag but I think for semantic release to do it all you need to remove the last 1.0.0 commit. I'm unable to do that

@humbertogontijo
Copy link
Owner

I deleted the last commit and its running again

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 9, 2024

I deleted the last commit and its running again

looks like it worked - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humbertogontijo humbertogontijo humbertogontijo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lash-L @humbertogontijo