Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply changes suggested by Barry Leiba. #14

Merged
merged 6 commits into from
Mar 9, 2020
Merged

Apply changes suggested by Barry Leiba. #14

merged 6 commits into from
Mar 9, 2020

Conversation

huitema
Copy link
Owner

@huitema huitema commented Mar 4, 2020

Close #13

@huitema huitema requested a review from kaiserd March 4, 2020 20:50
@huitema
Copy link
Owner Author

huitema commented Mar 4, 2020

This PR takes into account the changes suggested by Barry. Most of the changes are simple, but we need to check two points:

  1. I placed MDNS and DNSSD as normative references. Are there other references that should be classified as such?

  2. Barry observed that using MDNS as the reference for sleep proxies was very loose, and he is right. The problem is that there are very few good publications describing sleep proxies. When I checked that, I mostly got references to specs by Intel or Apple that were shared with implementers under NDA. I found an old web page by @StuartCheshire describing the sleep proxy on the MAC and I used that, but I would prefer an open spec or an academic reference.

@huitema
Copy link
Owner Author

huitema commented Mar 6, 2020

Also addressed the comments by Roman Danyliw.

Close #15

@huitema
Copy link
Owner Author

huitema commented Mar 6, 2020

Close #16

@huitema
Copy link
Owner Author

huitema commented Mar 7, 2020

Close #17

@huitema
Copy link
Owner Author

huitema commented Mar 7, 2020

At this point, the PR is ready and addresses pretty much all the comments. Waiting for reviews before submitting before the IETF cut-off time.

@huitema
Copy link
Owner Author

huitema commented Mar 9, 2020

Checking in, as draft 04 was submitted.

@huitema huitema merged commit 906eccb into master Mar 9, 2020
@huitema huitema deleted the barry-s-review branch March 9, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barry Leiba's review -- part of IESG evaluation
1 participant