Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👨‍🍳 Clarify DPO data preparation #2512

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Dec 21, 2024

What does this PR do?

Have a unique _prepare_dataset function.
Support for:

  • DatasetDict for eval dataset
  • Iterable datasets

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec requested review from kashif and lewtun December 21, 2024 00:06
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec merged commit 8fb267f into main Dec 22, 2024
14 checks passed
@qgallouedec qgallouedec deleted the clarify-dpo-data-prep branch December 22, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants