Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👁️ Added SFT support for SmolVLM models via standalone script sft_vlm_smol_vlm.py #2409

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

sergiopaniego
Copy link
Contributor

@sergiopaniego sergiopaniego commented Nov 28, 2024

What does this PR do?

Fixes #2408

This PR presents a standalone version for adding support to SmolVLM models. It may benefit from a generalization to be compatible with sft_vlm.py (similar idea that for #2236)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

@lewtun @edbeeching @qgallouedec

@sergiopaniego
Copy link
Contributor Author

Working example: notebook

The changes could also be integrated in sft_vlm.py since they are small:

  • A new import for the model
  • Below image:

image

@qgallouedec
Copy link
Member

Looks good to me, thanks a lot @sergiopaniego

If by any chance you have model or curves to share?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sergiopaniego
Copy link
Contributor Author

@qgallouedec
Copy link
Member

you rock!

@qgallouedec qgallouedec changed the title [SFT VLM] Added support for SmolVLM models via standalone script sft_vlm_smol_vlm.py 👁️ Added SFT support for SmolVLM models via standalone script sft_vlm_smol_vlm.py Nov 28, 2024
@qgallouedec qgallouedec merged commit e1d7813 into huggingface:main Nov 28, 2024
12 of 13 checks passed
@sergiopaniego sergiopaniego deleted the sft_vlm_smol_vlm branch November 28, 2024 17:49
@qgallouedec qgallouedec mentioned this pull request Nov 28, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SFT VLM] Add support for SmolVLM models
3 participants