Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCOTrainer conversational dataset support #2107

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Conversation

qgallouedec
Copy link
Member

What does this PR do?

Part of #2071

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice refactor! I left a comment about using this as an opportunity to switch the model/dataset to something more standard, but happy to leave that for a follow-up PR if you wish

docs/source/bco_trainer.mdx Outdated Show resolved Hide resolved
@@ -18,6 +18,8 @@
# Full training:
python examples/scripts/bco.py \
--model_name_or_path=nnheui/stablelm-2-1_6b-sft-full \
--trust_remote_code \
--dataset_name trl-lib/ultrafeedback-gpt-3.5-turbo-helpfulness \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can switch this to an unpaired version of trl-lib/ultrafeedback_binarized? That way we have two simple datasets that should "just" work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. How trl-lib/ultrafeedback_binarized is generated? Which "aspect" (helpfulness, ...) is used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge the PR, but we can work on it in a following PR

examples/scripts/bco.py Outdated Show resolved Hide resolved
@qgallouedec qgallouedec merged commit 44a06fc into main Sep 24, 2024
10 checks passed
@qgallouedec qgallouedec deleted the bco-conversational-dataset branch September 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants