Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model --> model_name_or_path #1452

Merged
merged 2 commits into from
Mar 19, 2024
Merged

model --> model_name_or_path #1452

merged 2 commits into from
Mar 19, 2024

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Mar 19, 2024

No description provided.

@lvwerra lvwerra requested a review from younesbelkada March 19, 2024 15:40
younesbelkada
younesbelkada approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again !

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lvwerra lvwerra merged commit 3f7ff60 into main Mar 19, 2024
9 checks passed
@lvwerra lvwerra deleted the fix-chat-model-name-2 branch March 19, 2024 15:52
lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
@lvwerra
model --> model_name_or_path (huggingface#1452)
90eb89d 
* `model` --> `model_name_or_path`

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvwerra @HuggingFaceDocBuilderDev @younesbelkada