Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chat model name #1451

Closed
wants to merge 5 commits into from
Closed

Fix chat model name #1451

wants to merge 5 commits into from

Conversation

lvwerra
Copy link
Member

@lvwerra lvwerra commented Mar 19, 2024

model -> model_name_or_path for chat

@lvwerra lvwerra requested a review from younesbelkada March 19, 2024 15:34
younesbelkada
younesbelkada approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! can you run the styling checks ?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lvwerra lvwerra closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvwerra @HuggingFaceDocBuilderDev @younesbelkada