Skip to content

Commit

Permalink
🧮 Fix max_steps calculation in RLOOTrainer (#2433)
Browse files Browse the repository at this point in the history
  • Loading branch information
qgallouedec authored Dec 3, 2024
1 parent 9ff79a6 commit 52201d3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion trl/trainer/rloo_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def repeat_generator():
# trainer state initialization
self.state.global_step = 0
self.state.episode = 0
self.state.max_steps = args.num_total_batches * args.num_mini_batches
self.state.max_steps = (args.num_total_batches * args.num_mini_batches) // 2
self.state.num_train_epochs = args.total_episodes / self.train_dataset_len
# Compute absolute values for logging, eval, and save if given as ratio
if args.logging_steps is not None:
Expand Down

0 comments on commit 52201d3

Please sign in to comment.