Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce Python 3.9 support for ModernBERT #35458

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

tomaarsen
Copy link
Member

What does this PR do?

Fixes https://huggingface.co/answerdotai/ModernBERT-base/discussions/21

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Reproduction

from typing import Tuple

foo: Tuple[int] | Tuple[str]

This script fails in Python 3.9:

Traceback (most recent call last):
  File "[sic]/demo_py39_test.py", line 4, in <module>
    foo: Tuple[int] | Tuple[str]
TypeError: unsupported operand type(s) for |: '_GenericAlias' and '_GenericAlias'

But works in Python 3.10+. See also https://bugs.python.org/issue42233

After this PR

With this PR in place, ModernBERT can be ran in Python 3.9.

Who can review?

@ArthurZucker
cc @warner-benjamin @KoichiYasuoka

  • Tom Aarsen

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@KoichiYasuoka KoichiYasuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this @tomaarsen

Copy link
Contributor

@warner-benjamin warner-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Tom!

@LysandreJik LysandreJik merged commit 5b516b0 into huggingface:main Jan 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants