Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop inplace operation for loss computation with gradient accumulation #35416

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Drop inplace operation for loss computation with gradient accumulation #35416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3700,7 +3700,7 @@ def training_step(
else:
# Finally we need to normalize the loss for reporting
if num_items_in_batch is None:
loss /= self.args.gradient_accumulation_steps
loss = loss / self.args.gradient_accumulation_steps

self.accelerator.backward(loss, **kwargs)

Expand Down
Loading