Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support telechat2 #35415

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

support telechat2 #35415

wants to merge 28 commits into from

Conversation

shunxing12345
Copy link

@shunxing12345 shunxing12345 commented Dec 25, 2024

What does this PR do?

Description

This PR introduces TeleChat2, a new model designed for [specific use case, e.g., multilingual conversational AI or general-purpose language modeling]. TeleChat2 supports model sizes of [e.g., 3B, 7B, and 35B] and has been pre-trained and fine-tuned on large datasets across English and Chinese.

Motivation

Adding TeleChat2 to the Transformers repository allows the community to benefit from its capabilities, leveraging state-of-the-art performance on [specific benchmarks or tasks]. This inclusion aligns with the repository's goal of supporting a diverse range of models and architectures.

Key Changes

  1. Added TeleChat2Config for model configuration.
  2. Added TeleChat2Model, TeleChat2ForCausalLM, and corresponding tokenizers.
  3. Included detailed documentation and tests to ensure compatibility and coverage.
  4. Updated integration points in AutoModel and other relevant files.

Documentation and Tests

  • Model architecture, configuration, and usage examples are documented in [relevant files].
  • Added unit tests for pretraining and fine-tuning workflows.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

xiangw2 and others added 23 commits December 18, 2024 13:37
Signed-off-by: xiangw2 <[email protected]>
fix
Signed-off-by: xiangw2 <[email protected]>
fix
Signed-off-by: xiangw2 <[email protected]>
fix
Signed-off-by: xiangw2 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
@shunxing12345
Copy link
Author

Hi team, 👋

Just following up on this PR. I understand you may have a lot on your plate, but I’d love to hear your thoughts or feedback on this contribution whenever you have time. Please let me know if there’s anything I can do to assist or improve the PR!

Thanks for your time and all the great work you do maintaining this repository! 🙏

Best,

shunxing12345 and others added 5 commits January 2, 2025 15:48
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
Signed-off-by: shunxing12345 <[email protected]>
@LysandreJik
Copy link
Member

Hey @shunxing12345 👋

Most of us are on holidays this week for the new year. The rhythm will pickup early next week and the team will review your PR as soon as possible. Thanks a lot for your patience and your contribution 🤗

@LysandreJik
Copy link
Member

cc @ArthurZucker feel free to ping someone for a first review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants