Add support for modular with fast image processors #35379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonigozlan
commented
Dec 21, 2024
Comment on lines
+127
to
+143
| def post_process_segmentation(): | ||
| raise NotImplementedError("Segmentation post-processing is not implemented for Deformable DETR yet.") | ||
|
|
||
| def post_process_instance(): | ||
| raise NotImplementedError("Instance post-processing is not implemented for Deformable DETR yet.") | ||
|
|
||
| def post_process_panoptic(): | ||
| raise NotImplementedError("Panoptic post-processing is not implemented for Deformable DETR yet.") | ||
|
|
||
| def post_process_instance_segmentation(): | ||
| raise NotImplementedError("Segmentation post-processing is not implemented for Deformable DETR yet.") | ||
|
|
||
| def post_process_semantic_segmentation(): | ||
| raise NotImplementedError("Semantic segmentation post-processing is not implemented for Deformable DETR yet.") | ||
|
|
||
| def post_process_panoptic_segmentation(): | ||
| raise NotImplementedError("Panoptic segmentation post-processing is not implemented for Deformable DETR yet.") |
There was a problem hiding this comment.
Here I wanted to remove these inherited functions. Somehow this works, but I'm not sure if there is a better way to do this?
Using modular the other way (with DetrImageProcessorFast inheriting from DeformableDetrImageProcessorFast) would solve the problem, but this wouldn't make sense chronologically.
yonigozlan
commented
Dec 21, 2024
Comment on lines
+553
to
+575
| def from_dict(): | ||
| raise NotImplementedError("No need to override this method for RT-DETR yet.") | ||
|
|
||
| def post_process(): | ||
| raise NotImplementedError("Post-processing is not implemented for RT-DETR yet.") | ||
|
|
||
| def post_process_segmentation(): | ||
| raise NotImplementedError("Segmentation post-processing is not implemented for RT-DETR yet.") | ||
|
|
||
| def post_process_instance(): | ||
| raise NotImplementedError("Instance post-processing is not implemented for RT-DETR yet.") | ||
|
|
||
| def post_process_panoptic(): | ||
| raise NotImplementedError("Panoptic post-processing is not implemented for RT-DETR yet.") | ||
|
|
||
| def post_process_instance_segmentation(): | ||
| raise NotImplementedError("Segmentation post-processing is not implemented for RT-DETR yet.") | ||
|
|
||
| def post_process_semantic_segmentation(): | ||
| raise NotImplementedError("Semantic segmentation post-processing is not implemented for RT-DETR yet.") | ||
|
|
||
| def post_process_panoptic_segmentation(): | ||
| raise NotImplementedError("Panoptic segmentation post-processing is not implemented for RT-DETR yet.") |
yonigozlan
commented
Dec 21, 2024
Comment on lines
+13
to
+15
| if dep_name == node_name: | ||
| # Skip self dependencies for topological sort as they create cycles | ||
| continue |
There was a problem hiding this comment.
This is the case in ijepa for example, where we import IJepaConfig in modular
yonigozlan
commented
Dec 21, 2024
| @@ -54,7 +59,7 @@ def extract_classes_and_imports(file_path): | |||
| for node in ast.walk(tree): | |||
| if isinstance(node, (ast.Import, ast.ImportFrom)): | |||
| module = node.module if isinstance(node, ast.ImportFrom) else None | |||
| if module and (".modeling_" in module): | |||
| if module and (".modeling_" in module or "transformers.models" in module): | |||
There was a problem hiding this comment.
@ArthurZucker @Cyrilvallez This was changed in a recent PR, but seems to have broken modular for generating files other than modeling
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for using modular with fast image processors
Also add a fix for using modular on files other than modeling, which seem to have been broken by a recent change
Who can review?
@Cyrilvallez