-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FSDP no longer working #35212
Fix FSDP no longer working #35212
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this change locally, I can confirm that it enables my testing example to run successfully. There is an exception, namely when flash attention is being used, for some reason (perhaps it's an issue with my setup). But even so, this is an improvement and can be merged from my point of view.
Failures are unrelated! |
What does this PR do?
#34140 introduced a breaking change that users are reporting has many downstream issues:
This PR reverts the breaking logic, while also maintaining the original test the user intended, in such a way that doesn't break downstream code. I'd highly recommend a patch with this fix @ArthurZucker
Fixes huggingface/peft#2205
Fixes axolotl-ai-cloud/axolotl#2149
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @winglian @SunMarc @BenjaminBossan