-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Core
] Refactor modeling code
#34987
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the rationale behind using different attention functions as opposed to different attention classes?
Moreover, I think it would be nice for all the new attention functions to have some sort of docstrings like we had in the classes.
f62d01f
to
f446bd4
Compare
…into llama-refactor
What does this PR do?
Refactor LlamaAttention following #34282