Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RWKV] Add RWKV6 model #34918

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[RWKV] Add RWKV6 model #34918

wants to merge 18 commits into from

Conversation

uniartisan
Copy link

What does this PR do?

This is currently a draft. I will supplement the documentation and related tests as soon as possible. RWKV6 and RWKV5 are derived from the same source, and I believe it is necessary to skip RWKV5 and only support RWKV6. After the RWKV7 pre-trained model is released, I will add support for RWKV7.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

Hi @uniartisan, this looks good, but can we rework the PR to use the new Modular style? It should make the PR much smaller and easier to write/review, since you can just import most of it from other models, including earlier RWKV models.

@uniartisan
Copy link
Author

Hi @uniartisan, this looks good, but can we rework the PR to use the new Modular style? It should make the PR much smaller and easier to write/review, since you can just import most of it from other models, including earlier RWKV models.

I can have a try later:)
The main issue is that I'm not very familiar with the previous RWKV models, though perhaps for the future RWKV7 I could reuse code from the current RWKV6. After I complete the tests and address other issues, I can try converting it to the modular style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants