Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new flax example for Bert model inference #34794

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

louie-tsai
Copy link

@louie-tsai louie-tsai commented Nov 18, 2024

What does this PR do?

Add a new Flax inference example and show case how to optimize performance with Bfloat16 data types.
Most of the Flax examples are for Training/Fine Tuning, so it should be a good reference for inference

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@ArthurZucker
@sanchit-gandhi
@stevhliu
@agramesh1
@mdfaijul

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a Flax example!

examples/flax/language-modeling/README.md Outdated Show resolved Hide resolved
examples/flax/language-modeling/README.md Outdated Show resolved Hide resolved
examples/flax/language-modeling/README.md Outdated Show resolved Hide resolved
examples/flax/language-modeling/README.md Outdated Show resolved Hide resolved
examples/flax/language-modeling/README.md Outdated Show resolved Hide resolved
examples/flax/language-modeling/README.md Outdated Show resolved Hide resolved
@louie-tsai louie-tsai requested a review from stevhliu November 27, 2024 01:11
@stevhliu
Copy link
Member

Thanks! Can you run make fixup or make style to fix the failing CI test (see step 5 here for more details)?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@louie-tsai
Copy link
Author

louie-tsai commented Dec 4, 2024

Thanks! Can you run make fixup or make style to fix the failing CI test (see step 5 here for more details)?
@stevhliu ran and fixed the issue accordingly. thanks

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, docs look good to me! Pinging @ArthurZucker for a quick review since I'm not too familiar with Flax 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants