[WIP] Add Moonshine #34784
Open
[WIP] Add Moonshine #34784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eustlb
force-pushed
the
add-moonshine
branch
from
bac9c9f to
d0ed917
Compare
eustlb
force-pushed
the
add-moonshine
branch
from
d4864c7 to
22dbaae
Compare
xenova
reviewed
Dec 15, 2024
src/transformers/models/moonshine/convert_usefulsensors_to_hf.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Lochner <[email protected]>
xenova
reviewed
Dec 16, 2024
xenova
reviewed
Dec 16, 2024
Co-authored-by: Joshua Lochner <[email protected]>
|
Indeed 😅 corrected, thanks !! |
xenova
reviewed
Dec 20, 2024
Comment on lines
+17
to
+18
| # moonshine | ||
|
|
There was a problem hiding this comment.
Suggested change
| # moonshine |
duplicate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for Moonshine to the Transformers library.
Moonshine builds on top of Whisper’s architecture to overcome some of its limitations, primarily the restriction to a fixed 30-second audio window.
Key improvements in Moonshine’s architecture:
1. It uses SwiGLU activation instead of GELU in the decoder layers.
2. Most importantly, it replaces absolute position embeddings with Rotary Position Embeddings (RoPE), enabling Moonshine to process audio inputs of any length—unlike Whisper, which is limited to fixed 30-second windows.
Who can review?
@ArthurZucker
TODO
modular_moonshine.py