-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) cleanup(Mask2Former): Remove unused level_start_index parameter #34498
Draft
philkuz
wants to merge
10
commits into
huggingface:main
Choose a base branch
from
philkuz:remove_level_set_index
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
5 tasks
philkuz
changed the title
cleanup(Mask2Former): Remove level_start_index parameter in Mask2former
cleanup(Mask2Former): Remove unused level_start_index parameter
Oct 29, 2024
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
philkuz
force-pushed
the
remove_level_set_index
branch
from
October 30, 2024 16:37
d08855c
to
4fa88e2
Compare
philkuz
changed the title
cleanup(Mask2Former): Remove unused level_start_index parameter
(WIP) cleanup(Mask2Former): Remove unused level_start_index parameter
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes an unused parameter in Mask2former code so that we can clean-up code that hurts export in #34393
Stacked on top of #34393. The specific commit of this PR is located here:
4fa88e2
(#34498)Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@qubvel @amyeroberts