Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) cleanup(Mask2Former): Remove unused level_start_index parameter #34498

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

philkuz
Copy link
Contributor

@philkuz philkuz commented Oct 29, 2024

What does this PR do?

Removes an unused parameter in Mask2former code so that we can clean-up code that hurts export in #34393

Stacked on top of #34393. The specific commit of this PR is located here:
4fa88e2 (#34498)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qubvel @amyeroberts

Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
Signed-off-by: Phillip Kuznetsov <[email protected]>
@philkuz philkuz changed the title cleanup(Mask2Former): Remove level_start_index parameter in Mask2former cleanup(Mask2Former): Remove unused level_start_index parameter Oct 29, 2024
Signed-off-by: Phillip Kuznetsov <[email protected]>
@qubvel qubvel added the Vision label Oct 30, 2024
@philkuz philkuz force-pushed the remove_level_set_index branch from d08855c to 4fa88e2 Compare October 30, 2024 16:37
@philkuz philkuz changed the title cleanup(Mask2Former): Remove unused level_start_index parameter (WIP) cleanup(Mask2Former): Remove unused level_start_index parameter Oct 30, 2024
@philkuz philkuz marked this pull request as draft October 30, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants