Un-deprecate timeout arg in pipelines #34382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @LysandreJik @Wauplin for review! |
Rocketknight1
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Thanks @Rocketknight1! Looks good. Let's wait for another review though
| @@ -916,6 +916,8 @@ def parse_args_from_docstring_by_indentation(docstring): | |||
|
|
|||
|
|
|||
| def compare_pipeline_args_to_hub_spec(pipeline_class, hub_spec): | |||
| ALLOWED_TRANSFORMERS_ONLY_ARGS = ["timeout"] | |||
There was a problem hiding this comment.
Maybe over-engineering things here but I would make this list pipeline-specific
There was a problem hiding this comment.
(feel free to ignore though, we can also do it next time a "transformers"-only arg is added)
There was a problem hiding this comment.
Yeah, it shouldn't be too painful to make that change when we need to!
|
(x-linking #34290 (comment) where this PR was discussed) |
Rocketknight1
force-pushed
the
un_deprecate_timeout
branch
from
b685a2d to
9cc9c6a
Compare
LysandreJik
approved these changes
Oct 28, 2024
Rocketknight1
force-pushed
the
un_deprecate_timeout
branch
from
9cc9c6a to
81d367c
Compare
2015aroras
pushed a commit
to 2015aroras/transformers
that referenced
this pull request
Nov 15, 2024
* Un-deprecate timeout * Put "timeout" on the allowed list * make fixup
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Un-deprecate timeout * Put "timeout" on the allowed list * make fixup
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
* Un-deprecate timeout * Put "timeout" on the allowed list * make fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the pipeline sync project, this PR allows some arguments in
transformersthat don't have to be in the Hub spec. This is limited to arguments that do not actually affect the core pipeline, liketimeout, which controls the timeout for downloading images passed as path arguments.