Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemma2 GGUF support #34002

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

yijun-lee
Copy link
Contributor

@yijun-lee yijun-lee commented Oct 7, 2024

What does this PR do?

Add GGUF support for Gemma2
#33260

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@LysandreJik LysandreJik requested a review from SunMarc October 7, 2024 16:23
@yijun-lee yijun-lee changed the title Add Gemma2 GGUF support Add Gemma2 GGUF support (WIP) Oct 10, 2024
@yijun-lee yijun-lee changed the title Add Gemma2 GGUF support (WIP) (WIP) Add Gemma2 GGUF support Oct 10, 2024
@yijun-lee yijun-lee changed the title (WIP) Add Gemma2 GGUF support [WIP] Add Gemma2 GGUF support Oct 11, 2024
@bekzod
Copy link

bekzod commented Oct 30, 2024

@yijun-lee really hoping this gets merged soon 🙏 really need this on our project

@yijun-lee
Copy link
Contributor Author

@yijun-lee really hoping this gets merged soon 🙏 really need this on our project

I’m working on it bit by bit whenever I have time🙂. I’ll make sure to wrap it up soon! Thank you for your interest !

@bekzod
Copy link

bekzod commented Oct 30, 2024

@yijun-lee thank you for your work, this helps a lot of people !

@SunMarc
Copy link
Member

SunMarc commented Nov 5, 2024

Feel free to tag me when this is ready !

@yijun-lee yijun-lee marked this pull request as ready for review December 30, 2024 06:34
@yijun-lee
Copy link
Contributor Author

@SunMarc
I realize I’ve left this task unattended for quite some time now 😅
But it’s finally complete—I’d greatly appreciate your review!

@yijun-lee yijun-lee changed the title [WIP] Add Gemma2 GGUF support Add Gemma2 GGUF support Dec 30, 2024
@SunMarc
Copy link
Member

SunMarc commented Dec 30, 2024

Thanks for the PR @yijun-lee ! @Isotr0py have a PR that refactor quite a bit the GGUF integration, so that we don't need to specify the tensor mapping. However, we still need the GGUFGemmaConverter that you coded. I'll let him review and decide if we merge this before or after his PR gets merged

Copy link
Contributor

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the Gemma2 support introduced in this PR on my PR, and tests can still pass on that branch as well.

I'm fine to have this merged before my PR, because the only difference is the removal of GGUF_TENSOR_MAPPING, and there won't be too many conflicts.

tests/quantization/ggml/test_ggml.py Outdated Show resolved Hide resolved
@yijun-lee yijun-lee requested a review from SunMarc January 2, 2025 07:00
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then ! Thanks for iterating

@SunMarc SunMarc requested a review from LysandreJik January 2, 2025 13:43
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants