-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gemma2 GGUF support #34002
base: main
Are you sure you want to change the base?
Add Gemma2 GGUF support #34002
Conversation
@yijun-lee really hoping this gets merged soon 🙏 really need this on our project |
I’m working on it bit by bit whenever I have time🙂. I’ll make sure to wrap it up soon! Thank you for your interest ! |
@yijun-lee thank you for your work, this helps a lot of people ! |
Feel free to tag me when this is ready ! |
@SunMarc |
Thanks for the PR @yijun-lee ! @Isotr0py have a PR that refactor quite a bit the GGUF integration, so that we don't need to specify the tensor mapping. However, we still need the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the Gemma2 support introduced in this PR on my PR, and tests can still pass on that branch as well.
I'm fine to have this merged before my PR, because the only difference is the removal of GGUF_TENSOR_MAPPING
, and there won't be too many conflicts.
Co-authored-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then ! Thanks for iterating
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Add GGUF support for Gemma2
#33260
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.