Fix EncoderDecoder cache candidate edge case #33926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Oct 4, 2024
| past_key_values[idx][1][:, :, :max_length, :], | ||
| ) | ||
| ) | ||
| if past_key_values[idx] != ([],) * len(past_key_values[idx]): |
There was a problem hiding this comment.
Mmm speedwise some stuff might break compile but not sure candidate generator was supported. Also sorry again for this break, introduced in Mllama 😢 will be in patch.
|
Closing as it was fixed in #34135 ! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Whisper introduced
EncoderDecodercache, which in some cases - e.g distil whisper, can have empty cache layers. This aims to fix this.Note that this allows speculative decoding for Whisper again, but that the two linked issues still fails because the decoding with assistant decoder is not as fast, at least on my machine:
test_speculative_decoding_whisper_distil,test_speculative_decoding_distilcc @ArthurZucker @eustlb