Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-ar] Translated file : docs/source/ar/torchscript.md into Arabic #33079

Merged

Conversation

AhmedAlmaghz
Copy link
Contributor

What does this PR do?

Translated the docs/source/ar/torchscript.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

Copy link
Contributor

@abodacs abodacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

السﻻم عليكم
@AhmedAlmaghz
تمت المراجعة جزاء الله خيرا

docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
docs/source/ar/torchscript.md Outdated Show resolved Hide resolved
AhmedAlmaghz and others added 20 commits November 10, 2024 19:09
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz
Copy link
Contributor Author

Thank you @abodacs

@AhmedAlmaghz AhmedAlmaghz marked this pull request as ready for review November 10, 2024 16:25
@AhmedAlmaghz
Copy link
Contributor Author

AhmedAlmaghz commented Nov 10, 2024

The following pull requests have been added to the current pull request to be merged once:

@abodacs @stevhliu

Thank you

@AhmedAlmaghz
Copy link
Contributor Author

AhmedAlmaghz commented Nov 10, 2024

أخي عبدالله @abodacs هذا ما تم إنجازه في هذا القسم
إلى الامام إن شاء الله

DEVELOPER GUIDES

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor formatting issues then it should be ready :)

docs/source/ar/torchscript.md Show resolved Hide resolved
docs/source/ar/troubleshooting.md Outdated Show resolved Hide resolved
docs/source/ar/troubleshooting.md Outdated Show resolved Hide resolved
docs/source/ar/troubleshooting.md Outdated Show resolved Hide resolved
@AhmedAlmaghz
Copy link
Contributor Author

All Done! @stevhliu

Thank you

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@stevhliu stevhliu merged commit 6de2a4d into huggingface:main Nov 11, 2024
9 checks passed
2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 14, 2024
…ic (huggingface#33079)

* Add docs/source/ar/torchscript.md to Add_docs_source_ar_torchscript.md

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Merge troubleshooting.md with this Branch

* Update _toctree.yml

* Update torchscript.md

* Update troubleshooting.md

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 15, 2024
…ic (huggingface#33079)

* Add docs/source/ar/torchscript.md to Add_docs_source_ar_torchscript.md

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Merge troubleshooting.md with this Branch

* Update _toctree.yml

* Update torchscript.md

* Update troubleshooting.md

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz AhmedAlmaghz deleted the Add_docs_source_ar_torchscript.md branch November 29, 2024 04:18
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…ic (huggingface#33079)

* Add docs/source/ar/torchscript.md to Add_docs_source_ar_torchscript.md

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Merge troubleshooting.md with this Branch

* Update _toctree.yml

* Update torchscript.md

* Update troubleshooting.md

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
…ic (huggingface#33079)

* Add docs/source/ar/torchscript.md to Add_docs_source_ar_torchscript.md

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/torchscript.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Merge troubleshooting.md with this Branch

* Update _toctree.yml

* Update torchscript.md

* Update troubleshooting.md

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants