🚨🚨 TextGenerationPipeline: rely on the tokenizer default kwargs #31747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue
TextGenerationPipeline.preprocess
, where tokenization happens, has defined a few optional kwargs whose default value does not match the tokenizer defaults. This was causing:tokenizer
calls and the tokenspipeline
was seeing, using default arguments on bothadd_special_tokens
had to be manually set toTrue
in the pipeline, despite it already being the default in the tokenizer.(2 is a consequence of 1 :) )
This PR
🚨🚨 This PR changes the code to rely on the tokenizer's defaults when these flags are unset. This means some models using
TextGenerationPipeline
previously did not add a<bos>
by default, which (negatively) impacted their performance. In practice, this is a breaking change.Example of a script changed as a result of this PR: