-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some test files (tets/test_xxx_utils.py
) to tests/utils
#31730
Conversation
Hi @amyeroberts. The failures are irrelevant I think
But maybe it's better to wait them being fixed ? |
tets/test_xxx_utils.py
) to tests/utils
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Yeah it's irrelevant. Let's wait until the CI is fixed ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @ydshieh !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What does this PR do?
For our daily CI (and other scheduled CI) workflow, we collect the tests by using the folders under
tests
. However, there are some files undertests
too. For some test files, they containsTestCase
but their tests are not collected in the CI workflow run.This PR moves
tets/test_xxx_utils.py
intotests/utils
.To be very sure we don't miss any test, it's probably better to come up with a solution that will collect the tests from the files under
tests
but not in any of its sub-directory. But it's more complex and might take a bit more time to deal with.