Apply the change deprecating resume_download param to unchanged lines to be consistent across the source code
#31333
Conversation
…es to be consistent across the source code - Apply the change made in PR huggingface#30620
unscrew
changed the title
resume_download param to unchanged lines to be consistent across the source code
| @@ -536,7 +536,7 @@ def from_pretrained( | |||
| force_download (`bool`, *optional*, defaults to `False`): | |||
| Whether or not to force to (re-)download the configuration files and override the cached versions if | |||
| they exist. | |||
| resume_download: | |||
| resume_download (defaults to `None`): | |||
There was a problem hiding this comment.
It was decided in #30620 (comment) that simply resume_download: is fine in this context given it's a deprecated and unused parameter. It defaults to None but more importantly, it is completely ignored by downstream library.
| @@ -182,7 +182,7 @@ def from_pretrained(cls, pretrained_model_name_or_path: str, **kwargs): | |||
| def get_config_dict(cls, pretrained_model_name_or_path: str, **kwargs): | |||
| cache_dir = kwargs.pop("cache_dir", None) | |||
| force_download = kwargs.pop("force_download", False) | |||
| resume_download = kwargs.pop("resume_download", False) | |||
| resume_download = kwargs.pop("resume_download", None) | |||
There was a problem hiding this comment.
I have been told that usually the examples/ folder is not maintained or updated over time.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Apply the change deprecating 'resume_download' param to unchanged lines to be consistent across the source code
What does this PR do?
Apply the change made in PR - Respect resume_download deprecation #30620 to the rest of the source code where the param is used.
Follow-up fixes to issue #30618
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Tagging the author of PR - Respect resume_download deprecation #30620 @Wauplin