Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mamba2 #31331

Closed
wants to merge 2 commits into from
Closed

Add Mamba2 #31331

wants to merge 2 commits into from

Conversation

zzhhjjj
Copy link
Collaborator

@zzhhjjj zzhhjjj commented Jun 8, 2024

What does this PR do?

Fixes #31204 (issue)

@amyeroberts
Copy link
Collaborator

cc @ArthurZucker

@vasqu
Copy link
Contributor

vasqu commented Jun 10, 2024

This doesn't look like Mamba2 at all, just a copy-paste of Jamba. Is it meant to be a placeholder for now?

One can easily see it as mamba2 doesn't use attention (except for some ablation studies) and the core (trition) functions mamba_chunk_scan_combined and mamba_split_conv1d_scan_combined are not even imported. Not to be rude but what's the purpose behind this PR? 😅

@Adibvafa
Copy link
Contributor

@vasqu I agree. Do you wanna work on a PR together?

@vasqu
Copy link
Contributor

vasqu commented Jun 14, 2024

@Adibvafa look into the issue #31204 , you can help me there or I can help here / a different PR if this is not being continued.

@ArthurZucker
Copy link
Collaborator

Feel free to open a PR and maybe leverage the new diff conversion! #30868

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mamba2
5 participants