Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My attempt to #31205, most of the work were already done in #28221. I just added the adoption in
detr
and include new tests in bothvideomae
anddetr
as suggested.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts @ikergarcia1996
The tests might be a bit artificial would love to switch it to a more realistic use case, e.g maybe make a list of actual videos and images. The image processor from
videomae
didn't really triggered the recursive check but the one fromdetr
did. Let me know if this is what you are looking for and then I will fix the rest ofdetr
variants.