Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Spanish translation of tokenizer_summary.md #31154

Merged
merged 15 commits into from
Jun 3, 2024

Conversation

aaronjimv
Copy link
Contributor

What does this PR do?

Add the Spanish version of tokenizer_summary.md to transformers/docs/source/es.

Fix some broken links in the en/ version.

#28936

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu

@aaronjimv
Copy link
Contributor Author

cc: @tadeodonegana@gisturiz

Hello guys! I always appreciate your help with the translation review, I am open to any feedback. Thank you for your help.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for also fixing the links in the English version 🤗

docs/source/es/tokenizer_summary.md Outdated Show resolved Hide resolved
docs/source/es/tokenizer_summary.md Outdated Show resolved Hide resolved
docs/source/es/tokenizer_summary.md Outdated Show resolved Hide resolved
Copy link

@tadeodonegana tadeodonegana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always @aaronjimv, i just left one minimal comment!


<Youtube id="VFp38yj8h3A"/>

Como vimos en [el tutorial de preprocessamiento](preprocessing), tokenizar un texto es dividirlo en palabras o subpalabras, que luego se convierten en indices o ids a través de una tabla de búsqueda. Convertir palabras o subpalabras en ids es sencillo, así que en esta descripción general, nos centraremos en dividir un texto en palabras o subpalabras (es decir, tokenizar un texto). Más específicamente, examinaremos los tres principales tipos de tokenizadores utilizados en 🤗 Transformers: [Byte-Pair Encoding (BPE)](#byte-pair-encoding), [WordPiece](#wordpiece) y [SentencePiece](#sentencepiece), y mostraremos ejemplos de qué tipo de tokenizador se utiliza en cada modelo.
Copy link

@tadeodonegana tadeodonegana Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change preprocessamiento to preprocesamiento, i believe this is a typo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tadeodonegana, thanks for comment it! I appreciate the help.

@aaronjimv aaronjimv requested a review from stevhliu June 3, 2024 20:15
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@stevhliu stevhliu merged commit c73ee13 into huggingface:main Jun 3, 2024
8 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
* add tokenizer_summary to es/_toctree.yml

* add tokenizer_summary to es/

* fix link to Transformes XL in en/

* translate until Subword tokenization section

* fix GPT link in en/

* fix other GPT link in en/

* fix typo in en/

* translate the doc

* run make fixup

* Remove .md in Transformer XL link

* fix some link issues in es/

* fix typo
@aaronjimv aaronjimv deleted the translate_tokenizer_summary branch June 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants