-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_proposal_pos_embed of deformable_detr support return dtype of proposal #30946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
src/transformers/models/deformable_detr/modeling_deformable_detr.py
Outdated
Show resolved
Hide resolved
…tr.py Co-authored-by: amyeroberts <[email protected]>
The lint problem is with other files. |
@DonggeunYu Indeed. I've tried re-running, but it doesn't appear to be using the new docker images (which it should). Could you try rebasing on main? |
@amyeroberts Done. |
@amyeroberts Please check this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@DonggeunYu Yesterday, we deprecated DETA. Could you rebase to include this change on main here? This will resolve the repo consistency check |
@amyeroberts Completed. |
@DonggeunYu My bad, the # Copied froms are still active. I've opened a PR to #31153 to remove these. Once merged, we can add that in and then we won't need to worry about DETA for this PR. Thanks for your patience! |
@DonggeunYu #31153 has been merged in. It would be good to still merge in this PR! I'll reopen. If you still wish to add and work on this, then adding upstream changes from main should fix the failing tests and I can merge. Otherwise fee lfree to close again :) |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Currently function
get_proposal_pos_embed
is fixed with return float32.Modified to return dtype of proposal.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?