Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TF weight conversion since we have full Safetensors support now #30786

Merged
merged 1 commit into from
May 14, 2024

Conversation

Rocketknight1
Copy link
Member

Transformers has a pt-to-tf script for generating TF weights. However, we don't really want people using this anymore - TF can load .safetensors fine, so adding tf_model.h5 is much less helpful than adding .safetensors.

This PR adds a deprecation warning, and hopefully we can remove the function entirely in a couple of versions.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1 Rocketknight1 merged commit 9ef3884 into main May 14, 2024
8 checks passed
@Rocketknight1 Rocketknight1 deleted the deprecate_tf_weight_conversion branch May 14, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants