[Gemma, Llama] Remove unused attribute #30327
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the
spaces_between_special_tokens
attribute fromGemmaTokenizer
andLlamaTokenizer
since that attribute doesn't do anything. This is because the_decode
method intokenization_utils.py
doesn't make use of this attribute, it only accepts a flag which defaults toTrue
.Alternatively, we could make sure that that attribute actually does something, by checking in the
_decode
method whether the tokenizer has it set. Up for discussion