Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test transposing image with EXIF Orientation tag #30319

Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Apr 18, 2024

What does this PR do?

Fixes issue transposing image with EXIF Orientation tag due to a change in the datasets library that will be included in the 2.19.0 release. See:

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fix the test by using PIL.Image to load the image from its URL instead of datasets ? It's a bit weird to rely on datasets to test the load_image function

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
Copy link
Member Author

I think it makes sense.

As there are 4 tests using datasets.load_dataset to load an image, I would wait for the opinion of the transformers maintainers.

@albertvillanova
Copy link
Member Author

@huggingface/transformers we need this PR to be merged before we can make the datasets release.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts amyeroberts merged commit c86d020 into huggingface:main Apr 18, 2024
18 checks passed
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
* Fix test with exif_transpose image

* Replace datasets with PIL to load image in tests
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
* Fix test with exif_transpose image

* Replace datasets with PIL to load image in tests
itazap pushed a commit that referenced this pull request May 14, 2024
* Fix test with exif_transpose image

* Replace datasets with PIL to load image in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants