-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test transposing image with EXIF Orientation tag #30319
Fix test transposing image with EXIF Orientation tag #30319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe fix the test by using PIL.Image to load the image from its URL instead of datasets
? It's a bit weird to rely on datasets
to test the load_image
function
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
I think it makes sense. As there are 4 tests using |
@huggingface/transformers we need this PR to be merged before we can make the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
* Fix test with exif_transpose image * Replace datasets with PIL to load image in tests
* Fix test with exif_transpose image * Replace datasets with PIL to load image in tests
* Fix test with exif_transpose image * Replace datasets with PIL to load image in tests
What does this PR do?
Fixes issue transposing image with EXIF Orientation tag due to a change in the
datasets
library that will be included in the 2.19.0 release. See:Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.