Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Spanish translation of pipeline_tutorial.md #30252

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

aaronjimv
Copy link
Contributor

What does this PR do?

Add the Spanish version of pipeline_tutorial.md to transformers/docs/source/es

Note:

There is a link to pipeline_tutorial#using-pipelines-on-a-dataset and reading the Spanish version of that doc es/pipeline_tutorial.md, I got the impression that it is incomplete. I would appreciate it if can confirm it.

Thanks.

#28936

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu

@aaronjimv
Copy link
Contributor Author

cc: @tadeodonegana@gisturiz

Hello guys, I would appreciate if you could review the translation. Thank you for your help.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation, the docs structure LGTM! We can merge once the content is reviewed :)

If you feel like pipeline_tutorial.md is incomplete, please feel free to open a separate PR to complete it!

@aaronjimv
Copy link
Contributor Author

Thanks for the translation, the docs structure LGTM! We can merge once the content is reviewed :)

If you feel like pipeline_tutorial.md is incomplete, please feel free to open a separate PR to complete it!

Ok! Thanks

@aaronjimv
Copy link
Contributor Author

Hello @stevhliu. I am still attentive to this PR, I wrote in the SomosNLP community requesting help to review the content.

In any case, I will re-tag @tadeodonegana and @gisturiz; I would appreciate your assistance.

Thank you.

Copy link

@tadeodonegana tadeodonegana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would only change the word mentioned in the comment below, since seudocódigo does not exist in the RAE dictionary. It is just a minimal change, but i think it is correct to change it.


<Tip warning={true}>

El ejemplo de código a continuación está escrito intencionalmente como seudocódigo para facilitar la lectura.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seudocódigo to pseudocódigo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tadeodonegana. Thanks for the feedback! I appreciate your help.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to you @aaronjimv , and sorry for the delay on reviewing this!

@aaronjimv aaronjimv requested a review from stevhliu April 25, 2024 18:50
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and thanks for following up! 🤗

@stevhliu stevhliu merged commit a98c417 into huggingface:main Apr 25, 2024
8 checks passed
@aaronjimv aaronjimv deleted the translate_pipeline_webserver branch April 25, 2024 23:29
itazap pushed a commit that referenced this pull request May 14, 2024
* add pipeline_webserver to es/

* add pipeline_webserver to es/, translate first section

* add comment for checking link

* translate pipeline_webserver

* edit pipeline_webserver

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants