Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grounding DINO] Add resources #30232

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

NielsRogge
Copy link
Contributor

What does this PR do?

This PR adds links to demo notebooks for Grounding DINO.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@NielsRogge NielsRogge requested a review from amyeroberts April 15, 2024 10:01
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a comment on making clear what is an isn't officially supported. This helps us in the future with issues if the notebooks become out-of-date with the library

docs/source/en/model_doc/grounding-dino.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/grounding-dino.md Outdated Show resolved Hide resolved
@NielsRogge
Copy link
Contributor Author

@amyeroberts feel free to approve and merge

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just two small changes to make before merge

docs/source/en/model_doc/grounding-dino.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/sam.md Outdated Show resolved Hide resolved
@NielsRogge NielsRogge merged commit 8c12690 into huggingface:main Apr 19, 2024
8 checks passed
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
* Add resources

* Address comments

* Apply suggestions from code review

Co-authored-by: amyeroberts <[email protected]>

---------

Co-authored-by: amyeroberts <[email protected]>
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
* Add resources

* Address comments

* Apply suggestions from code review

Co-authored-by: amyeroberts <[email protected]>

---------

Co-authored-by: amyeroberts <[email protected]>
itazap pushed a commit that referenced this pull request May 14, 2024
* Add resources

* Address comments

* Apply suggestions from code review

Co-authored-by: amyeroberts <[email protected]>

---------

Co-authored-by: amyeroberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants