Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix corner-case issue with the important models workflow #30212

Merged
merged 19 commits into from
Apr 16, 2024
Merged

FIX: Fix corner-case issue with the important models workflow #30212

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
693e7f5
Update push-important-models.yml
younesbelkada Apr 12, 2024
256793c
dummy commit
younesbelkada Apr 12, 2024
847f36b
Update modeling_bark.py
younesbelkada Apr 12, 2024
0501e7c
test
younesbelkada Apr 12, 2024
bcd169d
test
younesbelkada Apr 12, 2024
b64c433
test
younesbelkada Apr 12, 2024
b5ae6a8
another test
younesbelkada Apr 12, 2024
3de8c05
another test
younesbelkada Apr 12, 2024
6394c58
test
younesbelkada Apr 12, 2024
d3b879f
final test
younesbelkada Apr 12, 2024
7c864d0
final test
younesbelkada Apr 12, 2024
827c54e
test
younesbelkada Apr 12, 2024
c93167a
another test
younesbelkada Apr 12, 2024
9decf04
test
younesbelkada Apr 12, 2024
722191a
test
younesbelkada Apr 12, 2024
1a26ff3
another test
younesbelkada Apr 12, 2024
6a527d3
test llama
younesbelkada Apr 12, 2024
104b142
revert everything
younesbelkada Apr 12, 2024
cefb20e
remove echo
younesbelkada Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/push-important-models.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,12 @@ jobs:
test_modified_files:
needs: get_modified_models
name: Slow & FA2 tests
runs-on: ubuntu-latest
runs-on: [single-gpu, nvidia-gpu, a10, ci]
container:
image: huggingface/transformers-all-latest-gpu
options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/
if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' }}
if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && fromJson(needs.get_modified_models.outputs.matrix)[0] != null }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the most efficient condition i could use, simply converting to an array and trying to access to the first element seemed to work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we always going to be able to safely index on 0 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i think so , per my understanding if the array is empty fromJson(needs.get_modified_models.outputs.matrix)[0] will give null , so the check fromJson(needs.get_modified_models.outputs.matrix)[0] != null circumvents the case where the array is empty

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for confirming!

strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -133,4 +134,4 @@ jobs:
authkey: ${{ secrets.TAILSCALE_SSH_AUTHKEY }}
slackChannel: ${{ secrets.SLACK_CIFEEDBACK_CHANNEL }}
slackToken: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }}
waitForSSH: true
waitForSSH: true
Loading