Add FSDP config for CPU RAM efficient loading through accelerate #30002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
helloworld1
force-pushed
the
helloworld1/cpu_ram_efficient_loading
branch
from
68033fa to
8719a0f
Compare
helloworld1
force-pushed
the
helloworld1/cpu_ram_efficient_loading
branch
2 times, most recently
from
cf40b24 to
5443e5b
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
muellerzr
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Thanks! Overall this looks much better to me, just a slight documentation nit. cc @pacman100 so you're aware
|
Thanks for the suggestion. @muellerzr would you re-approve? |
|
No need for a reapproval in those cases :) The green checkmark in transformers is end-all-be-all approval unless something radically changed outside that. cc @amyeroberts for final review |
amyeroberts
reviewed
Apr 18, 2024
pacman100
approved these changes
Apr 18, 2024
Co-authored-by: Zach Mueller <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
helloworld1
force-pushed
the
helloworld1/cpu_ram_efficient_loading
branch
from
e7a1c8f to
e81cd98
Compare
amyeroberts
approved these changes
Apr 19, 2024
|
Running |
Co-authored-by: amyeroberts <[email protected]>
helloworld1
force-pushed
the
helloworld1/cpu_ram_efficient_loading
branch
from
73d8e4a to
a2978fb
Compare
zafstojano
pushed a commit
to zafstojano/transformers
that referenced
this pull request
Apr 22, 2024
…gingface#30002) * Add FSDP config for CPU RAM efficient loading * Style fix * Update src/transformers/training_args.py Co-authored-by: Zach Mueller <[email protected]> * Update src/transformers/training_args.py Co-authored-by: amyeroberts <[email protected]> * Add sync_module_states and cpu_ram_efficient_loading validation logic * Update src/transformers/training_args.py Co-authored-by: amyeroberts <[email protected]> * Style --------- Co-authored-by: Zach Mueller <[email protected]> Co-authored-by: amyeroberts <[email protected]>
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
) * Add FSDP config for CPU RAM efficient loading * Style fix * Update src/transformers/training_args.py Co-authored-by: Zach Mueller <[email protected]> * Update src/transformers/training_args.py Co-authored-by: amyeroberts <[email protected]> * Add sync_module_states and cpu_ram_efficient_loading validation logic * Update src/transformers/training_args.py Co-authored-by: amyeroberts <[email protected]> * Style --------- Co-authored-by: Zach Mueller <[email protected]> Co-authored-by: amyeroberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the environment variable
FSDP_CPU_RAM_EFFICIENT_LOADINGis being read here but are set intransformerscodebase. This change added option to setFSDP_CPU_RAM_EFFICIENT_LOADINGthroughcpu_ram_efficient_loadingFSDP option so jobs launched fromtorchrunor other means can take advantage ofFSDP_CPU_RAM_EFFICIENT_LOADINGthrough configs.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@pacman100
@muellerzr
@ArthurZucker
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.