Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin torch #28892

Merged
merged 4 commits into from
Feb 6, 2024
Merged

unpin torch #28892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
716bf1f
unpin torch
ydshieh Feb 6, 2024
ffe3a15
check
ydshieh Feb 6, 2024
603b36c
check
ydshieh Feb 6, 2024
76b1381
check
ydshieh Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .circleci/create_circleci_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ def job_name(self):
"pip install -U --upgrade-strategy eager .[sklearn,tf-cpu,torch,testing,sentencepiece,torch-speech,vision]",
"pip install -U --upgrade-strategy eager tensorflow_probability",
"pip install -U --upgrade-strategy eager -e git+https://github.com/huggingface/accelerate@main#egg=accelerate",
# TODO: remove this one after fixing the dependency issue(s) above
"pip install -U --upgrade-strategy eager torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu"
Comment on lines +286 to +287
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this, the torcuaudio at the end is not the the desired one and we get undefined symbol issue).
Some dependency make it downgraded to lower version, but I haven't been able to take a look.

],
marker="is_pt_tf_cross_test",
pytest_options={"rA": None, "durations": 0},
Expand Down
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@
"timeout-decorator",
"timm",
"tokenizers>=0.14,<0.19",
"torch<2.2.0",
"torchaudio<2.2.0",
"torchvision<0.17.0",
"torch",
"torchaudio",
"torchvision",
"pyctcdecode>=0.4.0",
"tqdm>=4.27",
"unidic>=1.0.2",
Expand Down
6 changes: 3 additions & 3 deletions src/transformers/dependency_versions_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@
"timeout-decorator": "timeout-decorator",
"timm": "timm",
"tokenizers": "tokenizers>=0.14,<0.19",
"torch": "torch<2.2.0",
"torchaudio": "torchaudio<2.2.0",
"torchvision": "torchvision<0.17.0",
"torch": "torch",
"torchaudio": "torchaudio",
"torchvision": "torchvision",
"pyctcdecode": "pyctcdecode>=0.4.0",
"tqdm": "tqdm>=4.27",
"unidic": "unidic>=1.0.2",
Expand Down
Loading